Page MenuHomePhabricator

Parser::extractSection() should not use same output type as Parser::preSaveTransform()
Closed, ResolvedPublic

Description

Author: conrad.irwin

Description:
implements described change

To fix bug 93 it is necessary to change the behaviour of <includeonly> tags
during preSaveTransform() but not during extractSections(). This could be done either by adding a new preprocessor flag, or by adding a new output type.

The latter is a better choice, as the current situation where OT_WIKI appears to be used for two things but is only used for one is very counter intuitive. Besides, I can't think of a good name for a flag to add to PPFrame::RECOVER_ORIG to indicate "<ignore>'s the contents of top-level <includeonly> tags instead of <ignore>ing the tags themselves".

OT_WIKI is currently used only for the PST. extractSections() overrides all power that OT_WIKI might have by setting PPFrame::RECOVER_ORIG.


Version: unspecified
Severity: enhancement

Attached:

Details

Reference
bz22602

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:03 PM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz22602.
bzimport added a subscriber: Unknown Object (MLST).