Page MenuHomePhabricator

AjaxLogin: Successful login does not update personal tools
Closed, DeclinedPublic

Description

Gentlemen,

When using AjaxLogin (r62754) and I log in correctly, the personal tools in the upper right corner do not update with my username/watchlist/preferences/etc. This does not update until I load the next page.

This is poor usability because it gives no indication to the user that they've successfully logged in.


Version: unspecified
Severity: enhancement

Details

Reference
bz22608

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 11:04 PM
bzimport added a project: AjaxLogin.
bzimport set Reference to bz22608.

Assuming AjaxLogin uses jQuery, here's two lines to stick after a successful login to fix this bug:

$j('.p-personal').html('<div class="mw-ajax-loader" />');
$j('.p-personal').load(window.location.href+' .p-personal > *' );

See, I did your work for you!

Created an AjaxLogin component for this extension

@ashley, this is one of the oldest tasks assigned to someone. Are you planning to work on it, and is its current priority correct?

@Qgil: no and no. I'm not actively working on AjaxLogin (and, if memory serves me correct, fixing this bug wasn't quite as simple as @werdna's comment suggested, or then I just failed at applying his patch).

Qgil removed ashley as the assignee of this task.Feb 14 2015, 4:18 PM
Qgil set Security to None.

Given the existence of Florian's awesome OOJsUIAjaxLogin extension, which actually works, looks modern and isn't a horrible pile of hacks on top of hacks, I'm going to say that AjaxLogin is deprecated in favor of OOJsUIAjaxLogin and thus I'm declining this task.