Page MenuHomePhabricator

parameter of Categorytree-member-num/-counts needs formatnum
Closed, DeclinedPublic

Description

When customize Categorytree-member-num there are 5 parameter, but only the last parameter has a call to formatnum. I think the call for the other parameter should do in the Extension and not in the message. Thanks.

The same for categorytree-member-counts.

All in CategoryTreeFunctions.php.


Version: unspecified
Severity: enhancement

Details

Reference
bz22798

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:03 PM
bzimport set Reference to bz22798.
bzimport added a subscriber: Unknown Object (MLST).

Created attachment 7250
untested patch

patch attached

attachment bug22798.patch ignored as obsolete

Created attachment 7409
untested patch 2: Add formatted numbers to categorytree-member-num

It is necessary to append new params with the formatted numbers, because there are often #expr in this message ([[mw:Extension:Categorytree#categorytree-member-num]]).

attachment bug22798-2.patch ignored as obsolete

Due to the new customization of that message (bug 29357), the formatnum for categorytree-member-num is optional, but categorytree-member-counts needs formatnum, because the numbers are visible in the tooltip.

Having formatnum on categorytree-member-num is nice to have, because all numbers in messages should go through formatnum