Page MenuHomePhabricator

Add stable=1 parameter to action=raw
Closed, DeclinedPublic

Description

action=render and action=raw did not work with stable=1 inside the 1.15 branch, looking at the labs wiki action=render now works with stable=1, however action=raw still does not follow the stable=1 param. That functionality is actually needed for a project I'm planning on using Flagged Revs on.


Version: unspecified
Severity: enhancement

Details

Reference
bz22823

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 11:05 PM
bzimport set Reference to bz22823.

What's bad about supporting stable=1 on raw? We already allow an oldid=# to control what revision is displayed, just as we do on render, view, edit... and those accept stable=1 as well, so I don't see any reason why allowing it to work on raw as well as all the other actions supporting oldid=# could pose any problem. You need to explicitly pass it, so it bots can't even get tripped up over it.

Also, RawPage would need a partial rewrite for this to be done right (would stable=1 use stable templates?), and there isn't really much motivation to do that.

It does have one hook *after* it generates everything, so using that would require duplication and throw-away CPU effort.

This is going to be pretty difficult to implement. Please raise this on mediawiki-l if you'd like to discuss.