Page MenuHomePhabricator

If oi_archive_name = '' give error instead of linking to obviously invalid url
Closed, ResolvedPublic

Description

Please see the URL. The oldest image thumb is missing. If you click it, you are taken to directory of the image thumbs. So you have the image history:

http://upload.wikimedia.org/wikipedia/commons/c/c1/Resilient_Barnstar.png. http://upload.wikimedia.org/wikipedia/commons/archive/c/c1/

instead of

http://upload.wikimedia.org/wikipedia/commons/1/13/Barnstar-camera.png
http://upload.wikimedia.org/wikipedia/commons/archive/1/13/20080106201537!Barnstar-camera.png

I'm not sure if this is intentional. Perhaps if the old image is indeed actually missing, it is better generate an understandable error ?


Version: unspecified
Severity: minor
URL: http://commons.wikimedia.org/wiki/File:Resilient_Barnstar.png

Details

Reference
bz22847

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 11:06 PM
bzimport set Reference to bz22847.
bzimport added a subscriber: Unknown Object (MLST).

http://commons.wikimedia.org/wiki/File:Resilient_Barnstar.png

It knows there is no thumbnail, and says as such

So the link should not be built to point at no file

-shell

Change 151378 had a related patch set uploaded by Brian Wolff:
Making missing old files not try to render a thumbnail

https://gerrit.wikimedia.org/r/151378

Change 151378 merged by jenkins-bot:
Making missing old files not try to render a thumbnail

https://gerrit.wikimedia.org/r/151378

Output changed for such a case. Once the above is deployed to commons, can you verify the new behaviour is what you want?

Gilles raised the priority of this task from Low to Unbreak Now!.Dec 4 2014, 10:12 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Low.Dec 4 2014, 11:22 AM
Restricted Application added a subscriber: Matanya. · View Herald Transcript