Page MenuHomePhabricator

Modification to renderArrayMapTemplateObj function
Closed, ResolvedPublic

Description

Author: ejkp2

Description:
pathc to arraymaptemplate parser function

On some systems the arraymaptemplate parser function does not function correctly. This tracked to the function renderArrayMapTemplateObj where it appears that the return value of virtualBracketedImplode (a pointer to a PPNode_Hash_Array object) should be used to extract the "value" member of the PPNode_Hash_Array object. I am including a patch that I have tested on my system (Mediawiki 1.15.2, PHP 5.2.10, MySQL 5.0.77, Semantic Mediawiki 1.5.0, Semantic Forms 1.9)


Version: unspecified
Severity: normal
OS: Linux

Attached:

Details

Reference
bz22861

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:07 PM
bzimport set Reference to bz22861.

Created attachment 7224
2nd attempt at a patch for solving #arraymaptemplate hash problem in SF

Attached:

Hi, thanks for the patch. This code doesn't work, though, for wikis (the majority of them) where hashing isn't being used. I created a new patch, based on your code, that I hope solves the problem - please let me know if it works for you.

This patch is now in version 1.9.1 of SF - I think this problem is now fixed.