Page MenuHomePhabricator

ethnio notice cookie isn't remembered properly
Closed, ResolvedPublic

Description

The notice supposedly should only be shown once, but some people report to have already seen it 20 times. That means that there might be something wrong with the setting/reading of the cookie value.

http://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Do_I_live_near_San_Francisco.3F_No_I_bloody_well_don.27t.21

Lack of attention for issues as these, causes people to add CSS to ignore ALL sitenotices ALWAYS. As such I think that any sitenotice has great responsibility to not muck it up for the rest.


Version: unspecified
Severity: normal

Details

Reference
bz22874

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 11:08 PM
bzimport set Reference to bz22874.
bzimport added a subscriber: Unknown Object (MLST).

bugs wrote:

Doesn't the cookie only get set when you click on the banner? (i.e. you open up the "sign up" form)

(In reply to comment #1)

Doesn't the cookie only get set when you click on the banner? (i.e. you open
up the "sign up" form)

I think so, yes. However, adding a [dismiss] link that hides the banner and sets the cookie should be trivial.

bugs wrote:

(In reply to comment #2)

I think so, yes. However, adding a [dismiss] link that hides the banner and
sets the cookie should be trivial.

If that's the case, then the cookie *is* actually being remembered properly, it's just not clear how to hide the banner. You're right though, adding a dismiss link shouldn't be a problem either.

I am entirely sure this has been fixed over time. During the last fundraiser I have hidden the banner and never received it again.