Page MenuHomePhabricator

Sighted index pages lack quality indicators from the ProofreadPage extension due to LinkHolderArray bug
Closed, ResolvedPublic

Description

Author: beau

Description:
The extension FlaggedRevs has been recently deployed on pl.wikisource.

Sighted index pages show no quality indicators from the Proofread Page extension. After reviewing an index page and purging it, quality indicators disappear. The only way to get them back is to remove the sighted flag.


Version: unspecified
Severity: normal
URL: https://secure.wikimedia.org/wikisource/pl/wiki/Indeks:Samuel_Bogumił_Linde_-_Słownik_języka_polskiego

Details

Reference
bz22981

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:03 PM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz22981.
bzimport added a subscriber: Unknown Object (MLST).

beau wrote:

Patch fixing the problem in the LinkHolderArray class

The current implementation of a LinkHolderArray ommits cached links in the call of the hook GetLinkColours.

This problem can be observed when a page is parsed multiple times. At the first time, everything is ok, because the linkCache is empty. After that the hook GetLinkColours is never called, because all links are cached ( $query is empty ).

Attached:

thomasV1 wrote:

thanks for the patch. I commited it.

thomasV1 wrote:

btw, it was r67993