Page MenuHomePhabricator

Don't make empty sections in the first place
Closed, ResolvedPublic

Description

Note the empty Variants section if one turns off stylesheets with
e.g., Firefox's Views->Page style.

If there are no variants, this section shouldn't be created in the
first place.

<!-- 1 -->
<div id="p-variants" class="vectorMenu emptyPortlet">
<h5><span>Variants</span><a href="#"></a></h5>
<div class="menu">

			</div>

</div>

<!-- /1 -->


Version: 1.17.x
Severity: enhancement
URL: http://transgender-taiwan.org/index.php?useskin=vector&uselang=en

Details

Reference
bz23026

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 11:07 PM
bzimport set Reference to bz23026.

What if someone wants to add them dynamically. That was the whole idea of leaving the UL there in the first place, but fine - fair point that it's invalid HTML. It's a balancing act at this point between what it is on load and what it may become afterward.

  • Bug 24500 has been marked as a duplicate of this bug. ***
  • Bug 25210 has been marked as a duplicate of this bug. ***
  • Bug 25366 has been marked as a duplicate of this bug. ***
  • Bug 26035 has been marked as a duplicate of this bug. ***

ayg wrote:

Making bug 24500 the bug for this because there's more discussion there.

*** This bug has been marked as a duplicate of bug 24500 ***