Page MenuHomePhabricator

Deletion reason menu should remove wiki markup
Closed, DeclinedPublic

Description

Author: darklama

Description:
When invoking action=delete, wiki markup is shown in the reasons menu, which can cause the menu to expand to great lengths. I think wiki markup for bold and italic text should be removed. I think wiki markup for links should be resolved and display the text that would be rendered instead.

For example given:

''[[Spam]]'' or '''[[Project:Vandalism|vandalism]]'''

the delete reason menu should display:

Spam or vandalism


Version: unspecified
Severity: enhancement

Details

Reference
bz23095

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 10:58 PM
bzimport set Reference to bz23095.
bzimport added a subscriber: Unknown Object (MLST).

alejrb wrote:

Unecessary probably - you can do this in 10 seconds with JavaScript, and you might want the wiki-markup displayed on some wikis etc. Write your own, or if you don't want to, I have one:
User:Ale_jrb/Scripts/csdcheck.js

happy.melon.wiki wrote:

I don't think this is something we should be forcing. And it serves as a good reminder of what is and isn't allowed in log summaries. WONTFIX.

  • Bug 26656 has been marked as a duplicate of this bug. ***

darklama wrote:

(In reply to comment #2)

I don't think this is something we should be forcing. And it serves as a good
reminder of what is and isn't allowed in log summaries. WONTFIX.

Links, italics, and bold are allowed in log summaries. Links are useful to point people to the policy that explains the reason for deleting. Italic and bold are useful to emphasis important points.

Like comments in source code, log summaries can help people understand the reasons why a page was deleted, and help the person that deleted it in the first place remember why they did so in the future.

If wiki markup was never intended to be allowed in log summaries, seems contradictory that the software does allow it.

happy.melon.wiki wrote:

The delete menu is a select dropdown; the behaviour of nested HTML elements in an <option> value is undefined. In Firefox an <a> tag is rendered in the dropdown list, but it is not clickable, and it is not rendered when the option is selected in the collapsed field, instead displaying only the link text. Bold and italics are not rendered in log summaries, and never have been AFAIK.

darklama wrote:

(In reply to comment #5)

The delete menu is a select dropdown; the behaviour of nested HTML elements in
an <option> value is undefined. In Firefox an <a> tag is rendered in the
dropdown list, but it is not clickable, and it is not rendered when the option
is selected in the collapsed field, instead displaying only the link text.
Bold and italics are not rendered in log summaries, and never have been AFAIK.

That is why I suggested wiki markup be stripped from <option> rather than translated into HTML markup. I was originally going to suggest a stripped version of the text be added to the label attribute as defined in HTML 4.01 for <option>, which web browsers are suppose to display for the option name instead when present, but Firefox apparently doesn't respect it.

I also had the idea of suggesting the use of drop menus similar to the ones used in the new edit toolbox which would instead allow the wiki markup to be interpreted and show a preview of the reason with links and all.

Maybe both choices could be included as preference options, while keeping the current behavior as the default?