Page MenuHomePhabricator

baseRevId should carry over preview/show changes
Closed, ResolvedPublic

Description

When do an "undo" and than use the preview or show changes button the request lost the information about the undo, so Extension cannot use this information, when save the page. Please reassigned the undo and undoafter parameter als hidden fields, so Extension can use this information.

This is relevant for FlaggedRevs, because the Extension fails on autosighted undo edits (see FlaggedRevsView.php, function addRevisionIDField for more details), after preview.

Thanks.


Version: unspecified
Severity: enhancement

Details

Reference
bz23098

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:58 PM
bzimport set Reference to bz23098.

Change to FlaggedRevs, because this can be fixed by reassign the old values of 'baseRevId' and 'undidRev' in FlaggedRevs and not set the fields on new values.

There is no need to do that with the undo fields, because the undo parameter are only need for get the content, not more.