Page MenuHomePhabricator

Patrolling pages is having issues (working though clicking states failure)
Closed, ResolvedPublic

Description

On patrolling, when patrolling new pages, the link [Mark as patrolled] at the bottom of the page, returns with the text [Could not patrol revision.], though when checking patrol log, or reloading RecentChanges, the work is patrolled.

Similar issue with the Ajax patrolling states that the same error message, though noting that when reloading that the patrol link has now disappeared as normal.

Sample page
http://en.wikisource.org/w/index.php?title=Page:A_Dictionary_of_Music_and_Musicians_vol_1.djvu/24&curid=362908&diff=1845445&oldid=1840686&rcid=1823581


Version: unspecified
Severity: major

Details

Reference
bz23132

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:01 PM
bzimport set Reference to bz23132.
bzimport added a subscriber: Unknown Object (MLST).

The AJAX patrolling is added by a script ([[m:User:Pathoschild/Scripts/Ajax_sysop]]). This indicates the problem also occurs when using the API.

Is there any chance that we can have a fix implemented to our patrolling at enWS that has occurred since the previous software upgrade. One would think that it would be a minor tweak that we could put to bed. Thanks.

Six months it has taken for this bug to progress nowhere and the bug came about due to a underlying MW application upgrade. I do not want to be a nuisance, however, it would nice to be able to get some of these things resolved. Seems difficult for Wikisource to get any movement on bugs, let alone on improvements. What is one to do? Some say silence is golden, they lied!

Fixing component, adding keyword code-update-regression since you claim it is "due to a underlying MW application upgrade".

I'm having trouble reproducing this bug. Here is what I did

*edited (logged out) the sandbox: http://en.wikisource.org/w/index.php?title=Wikisource%3ASandbox&action=historysubmit&diff=2149460&oldid=2149396

  • Logged back in, and marked that revision as patrolled.
  • Got the standard success message. No errors.

I also tried with creating a new page:
*created (logged out) http://en.wikisource.org/w/index.php?title=User:Bawolff/test&oldid=2149475
*Marked it as patrolled
*Yet again standard success message, no errors.

Could you please verify that the problem still exists, and if so give exact steps to reproduce the problem?

Alrighty, I tried with ajax patrolling thingy, and that is indeed broken. This is due to changes introduced in r61209. This is why js-y things should use the api, and not try to screen scrape things. (The ajax gadget assumes any response that does not contain "The selected revision has been marked as patrolled." as a failed response. Since the message no contains a link back to the article, the gadget fails to report status correctly.

This is not a mediawiki bug, unless you're getting this error without the use of javascript add-on tools. I recommend closing this INVALID.

Thanks for your investigation and identification of the problem through application of the knowledge. Knowing what is the issue will allow me to take your suggestions further.

Billinghurst changed the task status from Invalid to Resolved.Sep 27 2015, 3:37 AM
Billinghurst claimed this task.

Long resolved by other processes.