Page MenuHomePhabricator

Regression: Uploaded files are not longer added to watchlist even if "Add pages I create to my watchlist" is enabled in preferences
Closed, ResolvedPublic

Description

Regression: Uploaded files are not longer added to watchlist even if "Add pages I create to my watchlist" is enabled in preferences.


Version: 1.17.x
Severity: normal

Details

Reference
bz23167

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:03 PM
bzimport set Reference to bz23167.
bzimport added a subscriber: Unknown Object (MLST).

http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/api/ApiUpload.php?r1=64196&r2=64197&pathrev=64197

It looks like to me, that it never did (or at least, from the API's POV, it didn't tell it to)

		$watch = $this->getWatchlistValue( $params['watchlist'], $file->getTitle() ) || $wgUser->getOption( 'watchcreations' );

Would fix on the API..

(In reply to comment #1)

http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/api/ApiUpload.php?r1=64196&r2=64197&pathrev=64197

It looks like to me, that it never did (or at least, from the API's POV, it
didn't tell it to)

Tested as normal user in a 1.15: Yes, it works there. At time of calling Special:Upload the box is ticked already and after successfully upload the file is on my watchlist.

API done in r64955

Re the UI

<Bryan> some magic needs to be put in UploadForm::getOptionsSection

Bryan did the GUI in r64957

API fixed betterer in r64958