Page MenuHomePhabricator

special:newmessages gives internal error "Thread 689 has null title" on en wikinews
Closed, ResolvedPublic

Description

Got internal error with big long back traces on [[special:newmessages]] on enwikinews:


Internal error
From Wikinews, the free news source you can write!
Jump to:navigation, search

Thread 689 has null title

Backtrace:

#0 /usr/local/apache/common-local/wmf-deployment/extensions/LiquidThreads/classes/View.php(1736): LqtView->showThread(Object(Thread), 1, 2, Array)
#1 /usr/local/apache/common-local/wmf-deployment/extensions/LiquidThreads/classes/View.php(1907): LqtView->showThreadReplies(Object(Thread), 0, 25, true, Array, false)
#2 /usr/local/apache/common-local/wmf-deployment/extensions/LiquidThreads/classes/View.php(1736): LqtView->showThread(Object(Thread), 1, 1, Array)
#3 /usr/local/apache/common-local/wmf-deployment/extensions/LiquidThreads/classes/View.php(1907): LqtView->showThreadReplies(Object(Thread), 0, 25, true, Array, false)
#4 /usr/local/apache/common-local/wmf-deployment/extensions/LiquidThreads/classes/View.php(1736): LqtView->showThread(Object(Thread), 1, 1, Array)
#5 /usr/local/apache/common-local/wmf-deployment/extensions/LiquidThreads/classes/View.php(1907): LqtView->showThreadReplies(Object(Thread), 0, 25, true, Array, false)
#6 /usr/local/apache/common-local/wmf-deployment/extensions/LiquidThreads/classes/View.php(1736): LqtView->showThread(Object(Thread), 2, 2, Array)
#7 /usr/local/apache/common-local/wmf-deployment/extensions/LiquidThreads/classes/View.php(1907): LqtView->showThreadReplies(Object(Thread), 0, 25, true, Array, false)
#8 /usr/local/apache/common-local/wmf-deployment/extensions/LiquidThreads/classes/View.php(1736): LqtView->showThread(Object(Thread), 1, 1, Array)
#9 /usr/local/apache/common-local/wmf-deployment/extensions/LiquidThreads/classes/View.php(1907): LqtView->showThreadReplies(Object(Thread), 0, 25, true, Array, false)
#10 /usr/local/apache/common-local/wmf-deployment/extensions/LiquidThreads/classes/View.php(1736): LqtView->showThread(Object(Thread), 1, 1, Array)
#11 /usr/local/apache/common-local/wmf-deployment/extensions/LiquidThreads/classes/View.php(1907): LqtView->showThreadReplies(Object(Thread), 0, 25, true, Array, false)
#12 /usr/local/apache/common-local/wmf-deployment/extensions/LiquidThreads/pages/NewUserMessagesView.php(211): LqtView->showThread(Object(Thread), 1, 1, Array)
#13 /usr/local/apache/common-local/wmf-deployment/extensions/LiquidThreads/pages/NewUserMessagesView.php(156): NewUserMessagesView->showWrappedThread(Object(Thread))
#14 /usr/local/apache/common-local/wmf-deployment/extensions/LiquidThreads/pages/SpecialNewMessages.php(74): NewUserMessagesView->show()
#15 /usr/local/apache/common-local/wmf-deployment/includes/SpecialPage.php(559): SpecialNewMessages->execute(NULL)
#16 /usr/local/apache/common-local/wmf-deployment/includes/Wiki.php(254): SpecialPage::executePath(Object(Title))
#17 /usr/local/apache/common-local/wmf-deployment/includes/Wiki.php(64): MediaWiki->handleSpecialCases(Object(Title), Object(OutputPage), Object(WebRequest))
#18 /usr/local/apache/common-local/wmf-deployment/index.php(117): MediaWiki->performRequestForTitle(Object(Title), NULL, Object(OutputPage), Object(User), Object(WebRequest))
#19 /usr/local/apache/common-local/live-1.5/index.php(3): require('/usr/local/apac...')
#20 {main}


Version: unspecified
Severity: major
URL: http://en.wikinews.org/wiki/special:newmessages

Details

Reference
bz23199

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:05 PM
bzimport set Reference to bz23199.

Note: this only happens for my special:newmessages. Other users are not affected (I assume other users don't have thread 689 on their unread thread list?)

Trying to manually mark thread 689 as 'read' using the api by hand results in a 500 error, with no response body....

p.s. This is also now affecting more users than just me on wikinews.

Sorry, looks like the 500 error is unrelated to this bug since it happens for any page in the thread namespace that does not exist. Filing as a separate bug.

However, doing http://en.wikinews.org/w/api.php?action=query&list=threads&thid=689&thrender does result in blankpage/500 error, so its probably related.

According to the api, the thread in question has a rootid of 0 - http://en.wikinews.org/w/api.php?action=query&list=threads&thid=689&thprop=parent|ancestor|rootid|type I assume that has something to do with the problem

p.s. Sorry for bugspam, I've commented on this bug 4 times now without anyone else commenting in between...

Reopening as error is still present on [[special:newmessages]] and http://en.wikinews.org/w/api.php?action=query&list=threads&thid=689&thrender still gives me a blank page + 500 error.

I've made this fail gracefully for now (revision not yet deployed). Also added checks and balances to try to stop these sorts of buggy revisions from creeping into the DB.