Page MenuHomePhabricator

#formlink, #forminput 'query string=' parameter doesn't allow pipes in values
Closed, ResolvedPublic

Description

Author: mitchell_neill

Description:
Hi.

I have a formlink definition:

{{#formlink:Subsection Form|Add a Subsection|link type=button|Subsection
Template[Parent]={{PAGENAME}}&Subsection Template[Section
ID]={{{Section}}}&Subsection Template[Level]={{#op|{{{Level}}}|+|1}}}}

Level is a numeric property. {{#op|{{{Level}}}|+|1}} is a Winter
function that increments Level by one.

With SF 1.8.5 this works fine. The incremented Level appears correctly
in the Subsection template.

However, when I upgrade to SF 1.9 "<b>" appears in the Level field
instead of the incremented number. Clearly the {{#op|{{{Level}}}|+|1}}
is no longer being parsed correctly.

I updated the call format to:
{{#formlink:form=Subsection Form|link text=Add a Subsection|link
type=button|query string=Subsection
Template[Parent]={{PAGENAME}}&Subsection Template[Section
ID]={{{Section}}}&Subsection Template[Level]={{#op|{{{Level}}}|+|1}}}}

But it made no difference.


Version: unspecified
Severity: normal

Details

Reference
bz23211

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:06 PM
bzimport set Reference to bz23211.

mitchell_neill wrote:

Upping the importance as this query string= change busts a lot of existing functionality. You can't have pass anything but basic strings into forms now, which is really limiting.

Cheers
Neill.

mitchell_neill wrote:

Hi.

I've found another way of passing the variable in that works.

Yaron, close this if you want to unless you want to use this as an example of the query string= parsing not working fully.

Cheers
Neill.

Changing back to "normal" severity.

This was apparently fixed at some point between then and now. :) Setting to "fixed".