Page MenuHomePhabricator

Latest commit to LdapAuthentication (r65189) has typo on line 1324
Closed, ResolvedPublic

Description

Author: drstitch

Description:
The latest update of LdapAuthentication that came out this weekend
broke our LDAP authenticated wikis.

While I'm not a PHP expert, it would seem there's an errant '.' at the
end of line 1324 in LdapAuthentication.php (white space trimmed, line 1325
included) :

if ( ( isset( $wgLDAPGroupsPrevail[$_SESSION['wsDomain']] ).

&& $wgLDAPGroupsPrevail[$_SESSION['wsDomain']] ) && count( $this->userLDAPGroups ) != 0 ) {

If I remove the errant '.', my sites come back just fine. If that's not the
proper fix, let me know so I can start figuring out what else is borked.

Thanks!
-Tim Miller


Version: unspecified
Severity: major

Details

Reference
bz23257

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:09 PM
bzimport set Reference to bz23257.
bzimport added a subscriber: Unknown Object (MLST).