Page MenuHomePhabricator

bogus page/user invalidations
Closed, InvalidPublic

Description

CentralAuth is causing needless page/user invalidations.

Existing bad code paths:

  • Title cache invalidation should be done only when email settings actually changed

LoginForm::execute
LoginForm::processLogin
LoginForm::authenticateUserData
CentralAuthPlugin::updateUser
User::saveSettings
Title::invalidateCache

  • we should invalidate user cache only when there are changes that would need different rendering logic, not for every centralauthhooks session reload

User::getOption
User::loadOptions
User::load
User::loadFromSession
wfRunHooks
call_user_func_array
CentralAuthHooks::onUserLoadFromSession
CentralAuthHooks::initSession
User::invalidateCache


Version: unspecified
Severity: major

Details

Reference
bz23339

Related Objects

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:02 PM
bzimport set Reference to bz23339.
bzimport added a subscriber: Unknown Object (MLST).

lowering priority, unassigning reedy.

Think this is mostly done... shouldn't block 1.18

(In reply to comment #1)

http://svn.wikimedia.org/doc/
classUser_a124949b4a526ad6885f7f98816d3862d_icgraph.png

404 now. :-/

Wondering what's the status of this.

MarcoAurelio changed the task status from Open to Stalled.Sep 19 2015, 5:27 PM
MarcoAurelio subscribed.

Wondering what's the status of this.

Aklapper removed a subscriber: wikibugs-l-list.

Nobody has updated this task for seven years hence closing. @Domas: If there are still issues with the current codebase, then please file a new task. Thanks!