Page MenuHomePhabricator

mark articles as needing review after an included file is moved to Commons
Closed, ResolvedPublic

Description

If an article is reviewed and after this an embedded image in transfered from local wiki to commons and then the local image is deleted, the commons image is not shown but an blue link to the file page. You can only watch the image if you add ?stable=0

But the article is not marked as unreview nor a review link is shown at the article. To solve the problem you have to unreview the article first and then review the actual version.

For a quick solution it would help if all articles get unreviewed in their last version if an image is deleted.
This already happens if there is a never reviewed image and a new image version is uploaded. Then on all articles an review box is shown with "following images/templates have changed ....".


Version: unspecified
Severity: major

Details

Reference
bz23415

Event Timeline

bzimport raised the priority of this task from to High.Nov 21 2014, 11:07 PM
bzimport set Reference to bz23415.

File deletions handled in r67964.

Reopening - work still needed

Bug still exists. I have written a query on toolserver which shows about 10000 results on dewiki:
SELECT page_title, il_to

FROM dewiki_p.flaggedpages
 INNER JOIN dewiki_p.flaggedrevs ON fp_page_id = fr_page_id AND fp_stable=fr_rev_id
 INNER JOIN dewiki_p.imagelinks ON fp_page_id = il_from
 INNER JOIN dewiki_p.filearchive ON il_to = fa_name
 INNER JOIN dewiki_p.page ON fp_page_id = page_id
 LEFT JOIN dewiki_p.image i ON il_to = i.img_name
 INNER JOIN commonswiki_p.image ci ON il_to = ci.img_name
WHERE page_namespace=0 AND i.img_name IS NULL AND fa_deleted_timestamp > fr_timestamp AND fp_reviewed > 0;

Latest result is https://secure.wikimedia.org/wikipedia/de/w/index.php?title=Kaspar_Ritter_(Egg)#Heimatstilvilla_Nr._499 reviewed on 20110226180739 and image deleted later on that day (20110226180947).

I check many of these results and all still have the problem not showing the images. I'll start unreviewing/reviewing those page on dewiki soon to reduce the imact of this bug on dewiki.

bug 26527 looks like a duplicate

*** Bug 26527 has been marked as a duplicate of this bug. ***

(In reply to comment #6)

> *** Bug 26527 has been marked as a duplicate of this bug. ***

As noted there, the bug 15748 code is the cause of this.