Page MenuHomePhabricator

Right-click on navigation tab links doesn't work in IE
Closed, ResolvedPublic

Description

This is because the links are in <a><span>Link text</span></a>, which causes IE to show the right-click menu for clicking in limbo rather than the one appropriate for a link.


Version: 1.17.x
Severity: normal
URL: http://usability.wikimedia.org/wiki/Talk:What%27s_new,_questions_and_answers#Right_clicking_on_Page.2C_Edit.2C_History.2C_Discussion_etc._No_longer_allows_multi-tab_editing.2Freading.2C_Why.3F

Details

Reference
bz23490

Event Timeline

bzimport raised the priority of this task from to High.Nov 21 2014, 10:59 PM
bzimport set Reference to bz23490.

If we change it to <span><a>Link text</a></span> it will fix this, and the CSS stuff I need to do can still happen (i've checked) but it breaks allot of other stuff, like the watch/unwatch icon and all the scripts that expect a certain dom structure like CollapsibleTabs for instance.

  • Bug 23277 has been marked as a duplicate of this bug. ***
  • Bug 23516 has been marked as a duplicate of this bug. ***

For users looking for a workaround. If you have a middle mouse button and use that to click, the page is opened in a new tab.

nkomura wrote:

As ten Wikipedia projects are being affected by this bug and the share of IE8 is growing. The problem reports from German Wikipedia is coming in also. Let's look into the possibility of getting this bug fix out soon.

(In reply to comment #5)

As ten Wikipedia projects are being affected by this bug and the share of IE8
is growing. The problem reports from German Wikipedia is coming in also.
Let's look into the possibility of getting this bug fix out soon.

I will poke at this this weekend.

  • Bug 23983 has been marked as a duplicate of this bug. ***

(In reply to comment #6)

(In reply to comment #5)

As ten Wikipedia projects are being affected by this bug and the share of IE8
is growing. The problem reports from German Wikipedia is coming in also.
Let's look into the possibility of getting this bug fix out soon.

I will poke at this this weekend.

... or not. Now swamped in other things, reassigning to Adam.

LOL! This happens because SPAN hasLayout - go figure.

If you change display to inline and remove float then it works fine. Haven't checked on other browsers, but adding line-height:3.25em instead of padding-top:1.25em seem to work fine in IE8.

  • Bug 24210 has been marked as a duplicate of this bug. ***

amiller1 wrote:

Switched the markup around in r69317 to fix this.

(In reply to comment #11)

Switched the markup around in r69317 to fix this.

(...more than a month later, Usability Initiative now having been rolled out to all Wikimedia projects...)

If the above mentioned revision works, is it going to be rolled out? If it has been rolled out, it is not working.

Steps to reproduce: (Browser=IE7.0.6001.18000 Skin=default) Right-click on navigation tab links, popup menu for the wrong context appears.

I am not going to re-open this because I don't want to be a complete nuisance, but this is still undelivered six months after it was marked RESOLVED. From an end-user perspective, it looks like the "resolution" is WONTFIX.

(In reply to comment #14)

I am not going to re-open this because I don't want to be a complete nuisance,
but this is still undelivered six months after it was marked RESOLVED. From an
end-user perspective, it looks like the "resolution" is WONTFIX.

It is fixed in the software. This is the bug is in the MediaWire-core component. The software has been fixed as can be seen on any wiki running the latest nightly of the software.

This nightly isn't stable enough yet for a release, but word goes a release will be this or next month.
Either way, TranslateWiki.net is running the right off trunk and it's fixed there:
http://translatewiki.net/wiki/Main_Page

When Wikipedia will be upgraded to use this release is another story.