Page MenuHomePhabricator

wikibits.js KHTML fix is applied for Epiphany 2.28 and destroys left menu (Monobook skin)
Closed, ResolvedPublic

Description

Author: duststorm_design

Description:
Using epiphany 2.28 on Ubuntu Karmic (uses webtoolkit) the browser is detected as KHTML browser. (which could be part true)
But the KHTMLfix.css file actually destroys the left menu for epiphany. It is moved to the bottom of the page.
Using the default CSS works like a charm. (so no css fixes are needed for this browser)

navigator.userAgent.toLowerCase() for this browser is:
mozilla/5.0 (x11; u; linux i686; en-us) applewebkit/531.2+ (khtml, like gecko) safari/531.2+

What I did to fix this (but this is only a suggestion, I could be missing something):

in wikibits.js

Line 11 (insert): var is_epiphany = clientPC.indexOf('applewebkit') != -1 && clientPC.indexOf('mozilla') != -1;

Line 108 (replace): } else if (is_khtml && !is_epiphany) {

Mind that older versions of epiphany could be using gecko renderer (I believe v2.26 was available with both gecko and webkit) From 2.28 on they permanently chose to use webkit exclusively. Though I don't think this will cause problems with this fix.

I noticed this using Monobook skin, but this could probably occur on other skins as well.


Version: 1.15.x
Severity: normal
OS: Linux
Platform: PC

Details

Reference
bz23526

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:02 PM
bzimport set Reference to bz23526.

duststorm_design wrote:

Proposed patch for skins/common/wikibits.js (as explained in bug report)

Attached:

KHTMLFixes.css was already removed in r53141