Page MenuHomePhabricator
Create Task
Maniphest T25583

Special:Upload JS does not consider wgCheckFileExtensions
Closed, ResolvedPublic
Actions

Description

Author: spt5007

Description:
The upload interface will only accept files compliant with wgFileExtensions *even* if wgCheckFileExtensions is set to false. The problem is in the file:

/skins/common/upload.js

My suggested fix is to make wgCheckFileExtensions a "<script> global" in includes/Skin.php or similar and then check it's value before doing the actual file extension checking in upload.js

My System:

Ubuntu 10.04 x64
Mediawiki 1.16wmf4 (r66440)
PHP 5.3.2-1ubuntu4.1 (apache2handler)
MySQL 5.1.41-3ubuntu12

Version: unspecified
Severity: minor
Platform: Other

Details

Reference
bz23583
SubjectRepoBranchLines +/-
Check $wgCheckFileExtensions on client side on Special:Uploadmediawiki/coremaster+2 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 21 2014, 11:06 PM
• bzimport added a project: MediaWiki-Uploading.
• bzimport set Reference to bz23583.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.May 18 2010, 3:41 PM
• bzimport added a comment.May 18 2010, 4:10 PM

spt5007 wrote:

Proposed Patch

Attached:

checkExtensionsDiff1 KBDownload

• brion added a comment.Jan 2 2011, 8:48 PM
  • Bug 24731 has been marked as a duplicate of this bug. ***
• brion added a comment.Jan 2 2011, 8:49 PM

Hmm, perhaps it should just not export $wgFileExtensions if $wgCheckFileExtensions is off?

Peachey88 added a comment.Apr 30 2011, 12:09 AM

*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*

• bzimport added a comment.Nov 10 2011, 3:09 AM

sumanah wrote:

Per Brion's suggestion in comment 3 I'm adding the "reviewed" keyword. Thank you for the patch, Sean! If you have time, please do consider revising your patch for us; if you'd like tips on approach, please talk with us in MediaWiki-General on freenode IRC, or on https://lists.wikimedia.org/mailman/listinfo/wikitech-l . Thanks again.

• Gilles added a project: Multimedia.Nov 24 2014, 3:41 PM
Umherirrender claimed this task.Jan 12 2015, 7:44 PM
gerritbot added a project: Patch-For-Review.Jan 12 2015, 7:45 PM

Change 184411 had a related patch set uploaded (by Umherirrender):
Check $wgCheckFileExtensions on client side on Special:Upload

https://gerrit.wikimedia.org/r/184411

Patch-For-Review

gerritbot added a comment.Jan 12 2015, 8:02 PM

Change 184411 merged by jenkins-bot:
Check $wgCheckFileExtensions on client side on Special:Upload

https://gerrit.wikimedia.org/r/184411

Umherirrender mentioned this in rMW9fcca15d1dff: Check $wgCheckFileExtensions on client side on Special:Upload.Jan 12 2015, 8:03 PM
Krenair closed this task as Resolved.Jan 12 2015, 8:05 PM

Should be resolved now.

RandomDSdevel awarded a token.Mar 8 2015, 9:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL