Page MenuHomePhabricator

The formlink parser function sometimes breaks
Closed, DeclinedPublic

Description

Author: dan.bolser

Description:
I made a list of examples here:

http://sandbox.referata.com/wiki/Test1

Specifically, the problems include:

  • The 'query string' parameter can't be anonymous (I'm sure you know this, but I'm just logging it here).
  • Named parameters are sensitive to white space around the equals sign.
  • The 'query string' is sensitive to white space (I doubt this can be fixed without changing the syntax of the parser function).

If I ever get round to it I'll try to work on these minor problems.


Version: unspecified
Severity: enhancement

Details

Reference
bz23697

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:00 PM
bzimport set Reference to bz23697.

Marking this as "wontfix"... though maybe I should have gone with "fixed", or "invalid"... I'm fine with anonymous parameters to #formlink not getting handled correctly; it's not the correct syntax anyway (except for true query string parameters like "preload", but those work fine). I'm also fine with the query string parameter(s) not being able to include spaces, since those params are meant to be sent directly to the URL, which doesn't allow spaces.