Page MenuHomePhabricator

Useless "Deleted only" checkbox on page history and Special:Contributions for users unable to view deleted revisions
Closed, ResolvedPublic

Description

Author: matthew.britton

Description:
The page history filters show a "Deleted only" checkbox regardless of whether the user is able to view deleted revisions. This checkbox is completely useless to the vast majority of users, and should not be shown unless the user can view deleted revisions.


Version: unspecified
Severity: normal

Details

Reference
bz23721

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:02 PM
bzimport set Reference to bz23721.
bzimport added a subscriber: Unknown Object (MLST).

theevilipaddress wrote:

Furthermore, I think this button is pretty pointless if the page has no deleted revisions at all.

EN.WP.ST47 wrote:

This bug is still present, I have updated the summary to indicate /why/ the checkbox is useless, and I'm going to go ahead and mark this as an enhancement as the behavior is not strictly 'wrong', just non-optimal.

This really ought to be fixed up before 1.18 is released. It's pretty blatantly awful UI.

(In reply to comment #1)

Furthermore, I think this button is pretty pointless if the page has no deleted
revisions at all.

Split off into bug 32127. This is a separate issue.

(In reply to comment #2)

This bug is still present, I have updated the summary to indicate /why/ the
checkbox is useless, and I'm going to go ahead and mark this as an enhancement
as the behavior is not strictly 'wrong', just non-optimal.

I'm marking this as normal (not that it really matters...). It's not an enhancement to fix what is an obvious bug. Showing users a "deleted only" checkbox when it doesn't do anything is a bug, not a feature request.

(In reply to comment #5)

Gerrit change #27870

This is a good start, but doesn't resolve ?action=history.

I believe hiding this checkbox is appropriate. It was added in response to bug 20186. It's reasonable to want to filter a page history or Special:Contributions if you have the power to un-hide revisions. For typical users, the interface clutter simply isn't worth it, in my opinion.

(In reply to comment #6)

(In reply to comment #5)

Gerrit change #27870

This is a good start, but doesn't resolve ?action=history.

I believe hiding this checkbox is appropriate. It was added in response to bug

  1. It's reasonable to want to filter a page history or

Special:Contributions if you have the power to un-hide revisions. For typical
users, the interface clutter simply isn't worth it, in my opinion.

Done in PS3.