Page MenuHomePhabricator
Create Task
Maniphest T25822

search-redirect shows wrong Namespace
Closed, DeclinedPublic
Actions

Description

The information search-redirect shows a wrong namespace in the search result.

Part of the HTML:

<a href="/wiki/Hilfe:Weiterleitung" title="Hilfe:Weiterleitung">Hilfe:Weiterleitung</a> <span class='searchalttitle'>(redirect <a href="/wiki/Wikipedia:Falschschreibung" title="Wikipedia:Falschschreibung">Hilfe:<span class='searchmatch'>Falschschreibung</span></a>)</span>

  • Wikipedia:Falschschreibung - the redirect
  • Hilfe:Weiterleitung - the target of the redirect
  • Hilfe:<span class='searchmatch'>Falschschreibung</span> - the shown text, it has the wrong namespace at the begin (It should "Wikipedia:", not "Hilfe:").

I am not sure, if this a bug of the core or Lucene Search. Feel free, to move it to the right place.

Thanks.

Version: unspecified
Severity: enhancement
URL: http://de.wikipedia.org/w/index.php?title=Spezial%3ASuche&search=hilfe%3AFalschschreibung&fulltext=Volltext&uselang=en

Details

Reference
bz23822

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:09 PM
• bzimport added a project: MediaWiki-extensions-MWSearch.
• bzimport set Reference to bz23822.
Umherirrender created this task.Jun 7 2010, 7:07 PM
Umherirrender added a comment.Oct 29 2010, 10:06 AM

Changing to MWSearch, because it looks like the Extension is building that text

• demon added a comment.Feb 14 2014, 6:15 PM

Can you provide links where this is broken? Preferably a link where it's fixed in Cirrus ;-)

Umherirrender added a comment.Feb 14 2014, 8:13 PM

Use the url in the url field and you will still see the error

Hilfe:Weiterleitung (redirect Hilfe:Falschschreibung)

But the link behind 'Hilfe:Falschschreibung' is 'Wikipedia:Falschschreibung', so the text should also have the 'Wikipedia' in it.

Cirrus prefers the section over the redirect:

• demon added a comment.Feb 14 2014, 9:15 PM

(In reply to Umherirrender from comment #3)

Use the url in the url field and you will still see the error

I missed that, apologies

Hilfe:Weiterleitung (redirect Hilfe:Falschschreibung)

But the link behind 'Hilfe:Falschschreibung' is
'Wikipedia:Falschschreibung', so the text should also have the 'Wikipedia'
in it.

Cirrus prefers the section over the redirect:

https://de.wikipedia.org/w/index.
php?title=Spezial%3ASuche&search=hilfe%3AFalschschreibung&fulltext=Volltext&u
selang=en&srbackend=CirrusSearch

https://de.wikipedia.org/w/index.
php?title=Spezial%3ASuche&search=hilfe%3AFalschschreibung&fulltext=Volltext&u
selang=en&srbackend=LuceneSearch

Ok, I definitely see it here. I wonder if our behavior in Cirrus is the right thing though :)

• demon added a comment.Feb 17 2014, 5:10 AM
  • Bug 24026 has been marked as a duplicate of this bug. ***
Se4598 added a comment.Oct 15 2014, 12:02 PM

I think pretty sure the bug lies in this line:
https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FMWSearch.git/b327da0f987979b3be1e6c9d9d1c53e4197200b2/MWSearch_body.php#L211

The parameter $nsText seems to be referring in this context to the target ns, not to the redirect ns. But the real redirect ns is extracted later[1] for the title-object/linker as result of this call, but the erroneous snipped (displayed text) is already generated.

I'm feeling myself uncomfortable to fix this though as I'm not really understanding the whole code and unable to test it.

[1] https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FMWSearch.git/b327da0f987979b3be1e6c9d9d1c53e4197200b2/MWSearch_body.php#L220

Aklapper closed this task as Declined.Dec 5 2014, 12:20 AM
Aklapper claimed this task.

The MWSearch project has been archived as it is not under development anymore and superseded by CirrusSearch. Hence closing this task as declined.

If this still happens with CirrusSearch, please reopen this task by changing the status and adjust the projects of this task accordingly. Thank you!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL