Page MenuHomePhabricator

Shift enter in SimpleSearch opens results in original window AND tab
Closed, ResolvedPublic

Description

"Shift-Enter in Opera, which opens results in new tab, however in Vector the old tab goes to the results page as well."


Version: unspecified
Severity: minor
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=34756

Details

Reference
bz23866

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:59 PM
bzimport set Reference to bz23866.
bzimport added a subscriber: Unknown Object (MLST).

amiller1 wrote:

Tested in 9.6 and 10.10 on Mac OS X 10.6.2. Can't replicate this behavior. Actually I can't get any combination of modifier keys to even open a google search in a new window in either version of Opera. Doesn't seem like there are preferences to enable/disable this behavior either.

Feel free to reopen with more specifics about how to recreate this. I'll try it in Opera on windows next time I have a chance just to be sure.

alexsm333 wrote:

Shift-Enter in the input field does work in Opera (at least on Windows), opening results in a new tab (same as shift-clicking submit button). It also works on google.com with JS disabled (Google also messing up with JS, just like WP).

As of today, on 1.16wmf4 (r66620), behaviour is different: Shift-Enter works as Enter (Shift is ignored), however Shift-clicking the "zooming glass" button works, opening results in new tab.

I was the person who reported this on enwiki tech village, and although this will probably be wontfixed, I wanted to clarify.

alexsm333 wrote:

Update: right now I'm using the following personal .js code:

$j(function(){
$j('#searchform').bind('keyup keydown mousedown',

function (e){ $j(this).attr('target', e.shiftKey?'_blank':'')})

})

Works perfectly in major browsers, also works with shift-click on suggestion list. I'm considering adding this to Vector.js on my home WM wiki because it seems very useful.

Closing as WORKSFORME, unless somebody is willing to add this feature to MediaWiki.

(In reply to comment #3)

Update: right now I'm using the following personal .js code:

$j(function(){
$j('#searchform').bind('keyup keydown mousedown',

function (e){ $j(this).attr('target', e.shiftKey?'_blank':'')})

})

Works perfectly in major browsers, also works with shift-click on suggestion
list. I'm considering adding this to Vector.js on my home WM wiki because it
seems very useful.

Closing as WORKSFORME, unless somebody is willing to add this feature to
MediaWiki.

I don't see why we couldn't add this JS to MediaWiki. We'll probably want to check for Ctrl (Firefox on Windows/Linux) and Command (Firefox on Mac) as well.

Thehelpfulonewiki wrote:

Reassign to default per bug 37789

I'm an long-time Opera user, and I believe this bug was actually a problem in an old version of Opera. As far as I have been able to test, I have not been able to duplicate this bug. However, there is a similar bug in Vector that affects all browsers, reported in bug 34756. It causes the loss of work while editing.

If no one is still concerned about this bug, I think it should be closed as fixed, worksforme, or wontfix.

I tested this again with the new Opera 12.00 and this bug seems to no longer exist. Note that I never duplicated this bug with any version I tried, from about version 11.54 to 12.00, which are newer than the versions in use at the time the bug was reported. Somebody somewhere must have fixed the bug, so I'll close it now as FIXED.