Page MenuHomePhabricator

Broken Vector layout in IE 7 / 8 (and Linux browsers?..)
Closed, ResolvedPublic

Description

Author: claymore.ws

Description:
Broken Vector layout

It looks like recent update has broken Vector layout at least in IE 7 and IE 8. See the attachment and http://s13.radikal.ru/i186/1006/a0/04d0c0f9248a.jpg.

Chrome and Firefox on Windows XP seem to work, though.

I've tested this page: http://en.wikipedia.org/wiki/Category:Internet_Relay_Chat_networks


Version: unspecified
Severity: major

Attached:

BrokenVectorLayout.PNG (768×1 px, 74 KB)

Details

Reference
bz23881

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:00 PM
bzimport set Reference to bz23881.

Looks like a missing </div> in some message. But other than the <ul> issues fixed in r67799 the page is valid (and I see it correctly, too).

eugfed wrote:

(In reply to comment #1)

Looks like a missing </div> in some message. But other than the <ul> issues
fixed in r67799 the page is valid (and I see it correctly, too).

I can reproduce this bug.
Look at the screen shot:
http://i062.radikal.ru/1006/14/d584a1d63daf.png

When the layout is broken id attributes of div blocks in body do not have mw- prefixes.

claymore.ws wrote:

action=purge seems to fix the problem for me (IE 7). We can probably close the ticket now.

You are getting the post r67703 CSS but with the previous html. The easiest solution would be to purge enwiki cache from the squids. Alternatively, we could temporarily duplicate the changed rules with the old ids.

Since it was only deployed there, this only affects anonymous users at enwiki.

(In reply to comment #5)

You are getting the post r67703 CSS but with the previous html. The easiest
solution would be to purge enwiki cache from the squids. Alternatively, we
could temporarily duplicate the changed rules with the old ids.

Since it was only deployed there, this only affects anonymous users at enwiki.

It wasn't only deployed at enwiki, it was rolled out to nine more wikis yesterday.

This is a known issue. The site was broken like this for a few minutes this morning, and some broken pages made their way into cache. I will talk to Mark about this, I think he has an effective way of purging these specific pages from cache.

It wasn't only deployed at enwiki, it was rolled out to nine more wikis
yesterday.

Wasn't r67703 scapped and then deployed to the other wikis?

I will talk to Mark about this, I think he has an effective way of purging these specific pages from cache.

<mark> Setup live purging of all requests for vector enabled wikis, to remove some broken pages of this morning from the cache

Tentatively marking as fixed.

(In reply to comment #7)

It wasn't only deployed at enwiki, it was rolled out to nine more wikis
yesterday.

Wasn't r67703 scapped and then deployed to the other wikis?

Yes, but only the top 10 serve Vector to anons.

I will talk to Mark about this, I think he has an effective way of purging these specific pages from cache.

<mark> Setup live purging of all requests for vector enabled wikis, to remove
some broken pages of this morning from the cache

Tentatively marking as fixed.

Yeah, this should do it. This doesn't mean all broken pages are gone right now, but it does mean that a broken page should fix itself within 30 seconds after someone visits it.

I mean, if the other 9 wikis got vector enabled for anons after r67703 was (fully) scapped, it's not an issue for them.