Author: p.selitskas
Description:
A patch correcting the issue
I think this mess like <td width="80%" /> should be fixed. The sitenotice becomes moved to the left slightly, and it's not good for the eye.
Still must be tested in browsers (I'm not a pro in cross-browser css), but I suppose there are no unconventional styles. Nice for Chrome anyway.
Patch included.
Best wishes,
Paul Selitskas.
Version: unspecified
Severity: enhancement
Attached:
p.selitskas wrote:
(In reply to comment #1)
What issue is this fixing?
This one. The site notice is moved to the left because of the next <td /> with a 'hide' button. This patch fixes the problem leaving only one <td /> and a floated <span /> with the 'hide' button.
This appears to only change something for LTR languages. Please also implement the RTL case.
There's also a table-less proposal to do pretty much the same thing, on bug 25475. Is there a compelling reason we are using tables for this? Otherwise, the RTL fix to the patch could also replace the table with a div element.
(In reply to comment #3)
This appears to only change something for LTR languages. Please also implement
the RTL case.
Is the RTL fix still needed now that we have the [[mw:Directionality support#ResourceLoader|ResourceLoader]]?
I applied the patch in bug 25475, making the needed RTL fixes on the way. If i understand correctly the original report correctly, that patch solves the same problem.
This fix is not final and it may discussed further here: https://gerrit.wikimedia.org/r/#change,3951 .
Thanks to Paul for reporting and to Waldir for spotting the similarity.