Page MenuHomePhabricator

Thread summary -> Link to -> Link URL isn't a URL, just a relative path
Closed, ResolvedPublic

Description

Author: avarab

Description:
The code that gets the "Link URL" in the "link to" popup window is:

var linkURL = $j(this).attr('href');
var linkTitle = $j(this).parent().find('input[name=summary-title]').val();
liquidThreads.showLinkWindow( linkTitle, linkURL )

The problem is that href for that element is just a relative path, so I just get:

/Summary:Spjall/D%C3%A6mi_um_spjall%C3%BEr%C3%A1%C3%B0

Surely that should be an absolute URL?


Version: unspecified
Severity: minor

Details

Reference
bz24082

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 11:01 PM
bzimport set Reference to bz24082.
bzimport added a subscriber: Unknown Object (MLST).

avarab wrote:

Ah, clearly a bug at this page:

http://liquidthreads.labs.wikimedia.org/wiki/Talk:Main_Page#Questions_arise_1786

Clicking "Link to" will get you a relative url, but More -> Link to an absolute one.

ANother problem with relative links in bug 23382.

On page
https://www.mediawiki.org/wiki/Thread:Extension_talk:LiquidThreads/Adding_toolbar_section_and_group_to_WikiEditor
after clicking "More" and then on "Link To" I got a popup containing the url above in the "Link URL" field.

So, I assume this was already fixed.