john wrote:

Improved patch with proper usage of wfMsg and truncated comments

attachment UDP_on_comment_and_status_change.patch ignored as obsolete

(In reply to comment #1)

Created an attachment (id=7506) [details]
Improved patch with proper usage of wfMsg and truncated comments

+$wgCRUDPAddress = false;
+$wgCRUDPPort = false;
+$wgCRUDPPrefix = '';

I'd spell the CodeReview in full. Maybe also encapsulate the RecentChange::sendToUDP(...); line to keep those globals in one place only.

john wrote:

(In reply to comment #2)
> I'd spell the CodeReview in full. Maybe also encapsulate the

RecentChange::sendToUDP(...); line to keep those globals in one place only.

Sorry but what do you mean by "encapsulate the

RecentChange::sendToUDP(...); line", move it to its own function?

Yeah, I'd make a new function.

john wrote:

Patch version 3

This patch should address your requests. Let me know if it's missing anything.

Attached:

soxred93 wrote:

r70660

keywords: s/need-review/reviewed/.