Page MenuHomePhabricator

dumpBackup.php should warn if $wgDBAdmin* not set (patch expands documentation)
Closed, ResolvedPublic

Description

Author: debian

Description:
Hi,

The attached patch (for 1.15.4, but should fit 1.16 fairly easily) expands the documentation for maintenance/dumpBackup.php.

Notably, it also hints to the administrator that --conf can be used to specify the patch to LocalSettings.php if it's somewhere unexpected, instead of just crying and running away.

However, dumpBackup.php script still fails magnificently if $wgDBadmin.. are not set. It should warn and fall back on $wgDB.., since that'll probably be sufficient in most hosting environments.


Version: 1.15.x
Severity: normal

Details

Reference
bz24132

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:04 PM
bzimport set Reference to bz24132.

debian wrote:

expand documentation

Attached:

Manually applied patch to what was commandLine.inc in r75975

For the dumpBackup stuff... As of SVN head, pagelist has already been added...

--pagelist=<file>
            Where <file> is a list of page titles to be dumped

I think admin conf is now deprecated...? If someone else can confirm/deny, I'll apply the rest of the patch

Thanks!

r75976

Just the
"However, dumpBackup.php script still fails magnificently if $wgDBadmin.. are
not set. It should warn and fall back on $wgDB.., since that'll probably be
sufficient in most hosting environments." to deal with

(In reply to comment #0)

However, dumpBackup.php script still fails magnificently if $wgDBadmin.. are
not set. It should warn and fall back on $wgDB.., since that'll probably be
sufficient in most hosting environments.

I'm pretty sure this isn't true anymore since the maintenance rewrite.

Closing as FIXED, since the original doc expansion was done as requested. Per my earlier comment, I'm not truly sure that $wgDBadmin* needs to be set anymore.

Feel free to reopen if you can show this to still be an issue.