Page MenuHomePhabricator

When multiple "warn" filters are triggered, edit is prevented
Closed, ResolvedPublic

Description

Author: obliquemotion

Description:
Given a set of 3 filters:

#1: article_namespace == 0 & "orange" in lcase(added_lines)
#2: article_namespace == 0 & "red" in lcase(added_lines)
#3: article_namespace == 0 & "green" in lcase(added_lines)

where all 3 are set to give warning (but NOT prevented), edits that trigger combinations of these filters prevent the edit entirely. For example:

Edit session 1:

  1. Add line containing "GREEN"
  2. Click Save page: Warning for #3 displays
  3. Click Save page again: Edit goes through (correct behavior)

Edit session 2:

  1. Add line containing "GREEN and RED"
  2. Click Save page: Warning for #2 displays
  3. Click Save page again: Warning for #2 displays
  4. Click Save page again: Warning for #2 displays

...etc. The edit is prevented entirely, stuck in a loop.

  1. Click Cancel (abandon edit)

Edit session 3:

  1. Add line containing "GREEN, RED, and ORANGE"
  2. Click Save page: Warning messages for #1 and #3 display
  3. Click Save page again: Warning message for #2 displays
  4. Click Save page again: Warning messages for #1 and #3 display
  5. Click Save page again: Warning message for #2 displays

...etc. The edit is prevented entirely, stuck in a loop.

  1. Click Cancel (abandon edit)

Version: unspecified
Severity: major

Details

Reference
bz24167

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:06 PM
bzimport added a project: AbuseFilter.
bzimport set Reference to bz24167.

obliquemotion wrote:

Just tried it -- thanks!