Author: Nx.devnull

Description:
When the "Enable enhanced search suggestions (Vector skin only)" option is disabled, the suggestion dropdown doesn't appear. This is because the code in SimpleSearch.js runs regardless of the setting, and it activates the enhanced search suggestions, but because the simpleSearch div is missing from the output, the suggestion dropdown isn't positioned correctly and it is not visible.

If I'm not mistaken, this part:

if( !wgVectorEnabledModules.simplesearch || wgVectorPreferences.simplesearch.disablesuggest || skin != 'vector' ) {

return true;

}

needs to also check for !wgVectorPreferences.simplesearch.enable

Version: unspecified
Severity: minor