Page MenuHomePhabricator

Test case failure in UTF-8 normalization: CleanupTest.php
Closed, DeclinedPublic

Description

This is a bit worrying, since the given case is one of the most important ones -- UtfNormal::cleanUp() is supposed to normalize combining characters, and here it's not tripping correctly.

Not quite sure why this is failing, needs investigation.

The recent commit w/ iconv support doesn't seem to be tripping the issue for me. Tested so far w/ PHP 5.2 & 5.3 custom-built on Mac OS X 10.6.

$ /opt/php52/bin/php CleanUpTest.php
PHPUnit 3.4.15 by Sebastian Bergmann.

...F..........

Time: 11 seconds, Memory: 8.75Mb

There was 1 failure:

  1. CleanUpTest::testLatinNormal

Failed asserting that two strings are equal.

  • Expected

+++ Actual
@@ @@
-L'école
+L'école

/Library/WebServer/Documents/trunk/includes/normal/CleanUpTest.php:79
/Library/WebServer/Documents/trunk/includes/normal/CleanUpTest.php:407

FAILURES!
Tests: 14, Assertions: 66571, Failures: 1.


Version: 1.17.x
Severity: major
Whiteboard: aklapper-moreinfo

Details

Reference
bz24451

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 11:00 PM
bzimport set Reference to bz24451.
bzimport added a subscriber: Unknown Object (MLST).

Brion, are you still seeing this failure, or can we mark this one RESOLVED?

Brion: Could you please answer comment 1?

PHPUnit 3.7.0 or later required, you have 3.6.12.

wheeeeee

I'll let you know when I get that resolved.

Ok, so installing PHPUnit 3.7 doesn't appear to remove the hidden-somewhere 3.6.12 so I can't test this.

Ok got that resolved; somehow had two PEAR installs, and the one that things installed to wasn't the one being used. Sigh.

$ php phpunit.php includes/normal/CleanUpTest.php
PHPUnit 3.7.29 by Sebastian Bergmann.

Configuration read from /Library/WebServer/Documents/core/tests/phpunit/suite.xml

...............

Time: 628 ms, Memory: 11.75Mb

OK (15 tests, 17420 assertions)

I'll consider this a worksforme.