Page MenuHomePhabricator

Remove the "Indentation" button from edit toolbar
Closed, ResolvedPublic

Description

Since there is no wikitext markup for indentation, but <dd> of <dl> is being hugely abused instead (see bug 4521), the "Indentation" button - which does not insert indentation but definition - should be removed from edit toolbar until proper solution for indentation is implemented.


Version: unspecified
Severity: minor

Details

Reference
bz24489

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:02 PM
bzimport set Reference to bz24489.

*Mass-change: Move WikiEditor bugs to component and remove blocker bug where*

Shall I remove the button and submit a patch?

Change 93665 had a related patch set uploaded by 01tonythomas:
Removed the indentation button from the WikiEditor toolbar.

https://gerrit.wikimedia.org/r/93665

Change 94500 had a related patch set uploaded by Tinaj1234:
Removed indentation button from WikiEditor toolbar.

https://gerrit.wikimedia.org/r/94500

Created attachment 13752
Removed indentation button from WikiEditor toolbar.

Attached:

No need to duplicate patches to Bugzilla if they are in Gerrit already. :)

Change 102101 had a related patch set uploaded by Tinaj1234:
Removed indentation button from WikiEditor extension

https://gerrit.wikimedia.org/r/102101

Change 102101 abandoned by Tinaj1234:
Removed indentation button from WikiEditor extension

Reason:
This change previously exists. A patch was submitted earlier.
https://gerrit.wikimedia.org/r/#/c/94500/

https://gerrit.wikimedia.org/r/102101

Change 93665 abandoned by Tinaj1234:
Removed the indentation button from the WikiEditor toolbar.

Reason:
A patch with all required changes exists.
https://gerrit.wikimedia.org/r/#/c/94500/

https://gerrit.wikimedia.org/r/93665

Change 94500 merged by jenkins-bot:
Removed indentation button from WikiEditor toolbar.

https://gerrit.wikimedia.org/r/94500

Assuming this bug is FIXED as all patches were merged (or abandoned).
If that is not the case: Please reopen and elaborate what is left to do here to get this report fixed.