Page MenuHomePhabricator

UniversalEditButton
Closed, ResolvedPublic

Description

So far an wiki administrator has to insert $wgUniversalEditButton = true; into LocalSettings.php in order to activate the Universal Edit Button for browsers that support it. I think it would be good if an wiki administrator gets asked during the installing process, if it should be activated or not.


Version: 1.16.x
Severity: enhancement

Details

Reference
bz24496

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:03 PM
bzimport set Reference to bz24496.
bzimport added a subscriber: Unknown Object (MLST).

Maybe in 1.18. Not trying to add any more features to the new installer for 1.17.

markwdilley wrote:

My impression, which could be wrong, is that this was a standard on all Medawiki - so set to true would be the default.

Hope that is what is settled on :-)

As I observed the UEB is indeed already standard on all MediaWiki installations of Wikimedia. This bug is aiming on increasing the awareness of this feature for new wikis and making it as easy as possible to implement it there.

(In reply to comment #2)

My impression, which could be wrong, is that this was a standard on all
Medawiki - so set to true would be the default.

Hope that is what is settled on :-)

markwdilley wrote:

:-)

As I recall - it was supposed to be standard on all MediaWiki - out the box. I may have misunderstood what Brion told me though.

I like the idea of point blank asking an installer of the software because - you are right, it will help increase awareness!

:-)

$wgUniversalEditButton is set to true in DefaultSettings.php, so its always enabled unless the site admin explicitly disables it. Getting the installer to ask about every single configuration variable seems like a bad idea, as there are a lot, and many of them (like this one) 99% of people would not want to change.

Ups, most probably I mistyped the search query while looking for it in DefaultSettings.php Since this is the case, I agree with you that asking for it during installation is not a good idea. Thank you for solving this!

(In reply to comment #5)

$wgUniversalEditButton is set to true in DefaultSettings.php, so its always
enabled unless the site admin explicitly disables it. Getting the installer to
ask about every single configuration variable seems like a bad idea, as there
are a lot, and many of them (like this one) 99% of people would not want to
change.

(In reply to comment #6)

Ups, most probably I mistyped the search query while looking for it in
DefaultSettings.php Since this is the case, I agree with you that asking for it
during installation is not a good idea. Thank you for solving this!

Can confirm its there, Line 3968.
http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/DefaultSettings.php?view=markup#l3967