Page MenuHomePhabricator

Don't try to show log entries for the protected page upon editing if no log entries exist
Open, LowPublic

Description

If a page was protected a long time ago (earlier than the logging system) and someone tries to edit it, a message saying 'No matching log entries' appears above the text box. This may make users confused.


Version: unspecified
Severity: minor
Whiteboard: gci2014

Details

Reference
bz24511

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 11:04 PM
bzimport set Reference to bz24511.
bzimport added a subscriber: Unknown Object (MLST).

Changed summary: I suppose this is the solution? Anyway there must be very few pages like this, probably in the order of 10^1-2 across all Wikimedia projects.

  • Bug 21559 has been marked as a duplicate of this bug. ***
  • Bug 57407 has been marked as a duplicate of this bug. ***

(In reply to comment #1)

Changed summary: I suppose this is the solution? Anyway there must be very
few
pages like this, probably in the order of 10^1-2 across all Wikimedia
projects.

Nowadays however, this is becoming more visible again, due to revisiondelete. See repro at bug 57407.

  • Bug 67425 has been marked as a duplicate of this bug. ***

Any hints where in the codebase (or for which function) a new patch contributor should look?

Testcase: View https://www.mediawiki.org/w/index.php?title=User:Liangent/bug57407&action=edit logged in as non-sysop. It displays "No matching items in log."

This is the logempty message, as used by LogEventsList::showLogExtract()
It would have to present different messages, depending on the type of log being queried, taking into account the introduction dates of some of these logs.