Page MenuHomePhabricator

Search and replace dialog should not be modal
Closed, ResolvedPublic

Description

Search and replace dialog appears modal over the page, which gets obscured. This means among other things that the user cannot change the textarea while the dialog is open.

This is not a problem for Replace all, but when the user is doing find next / replace next, the text is hard to view, and cannot be scrolled or unmodified (to back out one replace next, change the focus to skip the point where it continues...).


Version: unspecified
Severity: major

Details

Reference
bz24566

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:08 PM
bzimport set Reference to bz24566.
bzimport added a subscriber: Unknown Object (MLST).

Adam, maybe you could play with making the dialog non-modal?

*Mass-change: Move WikiEditor bugs to component and remove blocker bug where*

Still no progress on this?

How is the user supposed to do repetitive changes to wikipages?

  • The tool doesn't let him to edit the page without closing the box;
  • If he close it, then the text which was selected by the search box won't be selected anymore;
  • If he uses "Replace all" instead, then the browser hungs up because of its slowness? (bug 23510)

These problems adds lots of unnecessary clicks to these kind of tasks which the 'search and replace' feature is supposed to help editors with.

Thehelpfulonewiki wrote:

Reassign to default per bug 37789

Anyone have a smart CSS check to differentiate between modal and non modal jquery dialogs ? Cause we might want to add a black border around that dialog to raise contrast a bit.