Page MenuHomePhabricator

MediaWiki:Pagetitle-view-mainpage has no effect on main page
Closed, DeclinedPublic

Description

Author: yackushevas

Description:
The "Pagetitle-view-mainpage" is defined as "example", however the
<title> element is not currently displaying this content. Instead, it displays
the default "Main Page - SITENAME" content.


Version: 1.16.x
Severity: enhancement
OS: Linux
Platform: PC

Details

Reference
bz24631

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 11:12 PM
bzimport set Reference to bz24631.
bzimport added a subscriber: Unknown Object (MLST).

yackushevas wrote:

Tried on the version from a trunk, in different languages - the effect is not present.

Have you tried making a null edit (i.e. an edit without changes) to the page?

yackushevas wrote:

(In reply to comment #2)

Have you tried making a null edit (i.e. an edit without changes) to the page?

I do not quite understand.

soxred93 wrote:

Follow the instructions at [[WP:NULL]] to make a null edit. Basically, you're saving a page without making any changes.

yackushevas wrote:

Yes, I made a null edit + cleared the cache. It did not help

yackushevas wrote:

I can I tell nonsense, but it is more to me comes to than nothing mind: there can be it because of a used database? At me PostgreSQL 8.4.4. Unfortunately to put MySQL for the test at present I can not.

njansen wrote:

Have the same problem. Also since Mediawiki 1.16.0.

mail wrote:

(In reply to comment #6)

I can I tell nonsense, but it is more to me comes to than nothing mind: there
can be it because of a used database? At me PostgreSQL 8.4.4. Unfortunately to
put MySQL for the test at present I can not.

I have the same problem since updating to 1.16.0 - I use MySQL 4.1.22 and PHP 5.2.12, so it is not because of using PostgreSQL.

I'm rather convinced that this is a regression in the 1.16.0 branch. Is there a keyword to tag this bug?

Fixed on trunk with r64876. We can backport changes related to setHTMLTitle() from it.

yackushevas wrote:

(In reply to comment #10)

Fixed on trunk with r64876. We can backport changes related to setHTMLTitle()
from it.

Has helped but only if to change this code location:

@@ -447,17 +447,9 @@

	/**
	 * "HTML title" means the contents of <title>.
	 * It is stored as plain, unescaped text and will be run through htmlspecialchars in the skin file.
  • * If $name is from page title, it can only override names which are also from page title,
  • * but if it is not from page title, it can override all other names. */
  • public function setHTMLTitle( $name, $frompagetitle = false ) {
  • if ( $frompagetitle && $this->mHTMLtitleFromPagetitle ) {
  • $this->mHTMLtitle = $name;
  • }
  • elseif ( $this->mHTMLtitleFromPagetitle ) {
  • $this->mHTMLtitle = $name;
  • $this->mHTMLtitleFromPagetitle = false;
  • }

+ public function setHTMLTitle( $name ) {
+ $this->mHTMLtitle = $name;

	}

If you change all file OutPage.php, I receive an error:

PHP Fatal error: Call to undefined method OutputPage::getFrameOptions() in /var/www/.../includes/Skin.php on line 416

This isn't fixed. The changes still need to be backported.