Page MenuHomePhabricator

Upload wizard: Error handling system
Closed, ResolvedPublic

Description

  • file determined bad after upload (zero length, cannot id format, etc.)
  • site temporarily unavailable
  • file bad upon entry into input (filename)
  • file identical to other files on wiki
  • constrain description/title for bad characters
  • file transfer stalled (in some browsers, is this even possible to detect??)
  • missing token (rewrite network use to re-obtain token transparently)

Version: unspecified
Severity: normal

Details

Reference
bz24695

Related Objects

StatusSubtypeAssignedTask
DeclinedNone
ResolvedNone
ResolvedNone

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:03 PM
bzimport added a project: UploadWizard.
bzimport set Reference to bz24695.

Not sure if this is relevant, but reading this list also brings permissions errors (user has no upload permission or, worse, loses it halfway through the wizard) and the wiki being in read-only mode.

neilk wrote:

Changes in wiki state whilst uploading seem like a corner case.

Anyway review bug#24699 for the more comprehensive answer to how it will work

neilk wrote:

infrastructure mostly there.

  • transparently obtaining token was added some time ago. (There can be timeout errors still).
  • errors on page 1 mostly dealt with, since r77136.

This is not quite a dupe of bug#25787 but is covering similar territory.

neilk wrote:

Considering this bug closed, at least insofar as it represents

  • missing token
  • site unavailable, unreachable
  • identical file handling
  • other upload API error handling

Lots of revisions have fixed this, but the last holes should be plugged with

r84221, r84223, r84224, r84226, r84286, r84301, r84303.

For description page API errors refer to bug 24758.

For description/title bad characters, see bug 24703

neilk wrote:

See previous comment.