Page MenuHomePhabricator

Upload wizard: API errors that block progress on description page submission
Closed, ResolvedPublic

Description

When saving the description on Step 3 to proceed to step 4, the upload wizard is stuck on Step 3 with the spinner spinning.

It may be a browser compatibility issue, I've asked people experiencing this issue to provide additional information.


Version: unspecified
Severity: normal
OS: other
Platform: Other

Details

Reference
bz24758

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:07 PM
bzimport added a project: UploadWizard.
bzimport set Reference to bz24758.
bzimport added a subscriber: Unknown Object (MLST).

neilk wrote:

Will reconsider this bug to be about any and all API errors that can block progress on the description page.

neilk wrote:

One reason this happens:

'badtoken' errors -- if session times out in between uploading and describing.

Solution -- wrap the final metadata POST in a "postWithApiEditToken" call as we do with initial upload. This will retry the post with a fresh token if it encounters a badtoken error.

neilk wrote:

(In reply to comment #2)

Except... we're already doing that?
The badtoken error *should* be impossible... unfortunately so far can't replicate

One reason this happens:

'badtoken' errors -- if session times out in between uploading and describing.

Solution -- wrap the final metadata POST in a "postWithApiEditToken" call as we
do with initial upload. This will retry the post with a fresh token if it
encounters a badtoken error.

neilk wrote:

Other errors that can occur

  • renameerror: if you accidentally enter a title like "foo.jpg", the system will try to rename it to "foo.jpg.jpg". Strip extensions, or disallow them

neilk wrote:

*** Bug 26076 has been marked as a duplicate of this bug. ***

neilk wrote:

blocking on 28577 since it describes the need for blacklist checking (which this bug just alludes to)

neilk wrote:

This bug breaks down into several parts.

If an error occurs on the details page submission, it should work like it did with errors on the upload page submission.

  1. - The UI should catch any and all errors.

Sort of done, but it doesn't do much with them now

  1. - Removing the failed submissions should be possible.

Progress made on this with r85694, can now remove an upload from anywhere, especially at a deeds interface. Now needs interface for Description page errors.

  1. - Retrying the failed submissions should be possible.
  1. - Errors which can be fixed by fixing the title should open up the interface again for that, and allow resubmission.
  1. - Errors with the title which can be avoided (such as Blacklist) should be surfaced earlier

Probably won't block on this for 1.0, as we have issues with TitleBlacklist that we don't understand now.

neilk wrote:

Oops, the previous comment for (2) should have linked to r86594

neilk wrote:

re: comment #7, points 1-5 have been implemented and bugs with each feature should be broken out when discovered

Gilles raised the priority of this task from Medium to Unbreak Now!.Dec 4 2014, 10:27 AM
Gilles added a project: Multimedia.
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Medium.Dec 4 2014, 11:20 AM