Page MenuHomePhabricator

Custom added tabs not collapse to menu on page resize
Closed, DeclinedPublic

Description

If custom tab is added before watchlist tab, on page resize it's ignored and stays in, only original tabs scroll/collapse to the menu.


Version: unspecified
Severity: minor

Details

Reference
bz24779

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:08 PM
bzimport set Reference to bz24779.
bzimport added a subscriber: Unknown Object (MLST).

Did you add class="collapsible" to the custom tab?

wiki.nihiltres wrote:

Adding class="collapsible" to the custom tab doesn't seem to help. The problem seems to be something involving the $settings variable, but I don't understand the code well enough to analyze the problem further.

TypeError: 'null' is not an object (evaluating '$settings.expandedContainer')

load.php:407

What are steps to reproduce this? How to add a custom tab?

This certainly works now, even if it didn't work before.

Tested using this JS:

mw.util.addPortletLink('p-views', '#', 'Test tab', 'ca-test', null, null, 'ca-history')
$('#ca-test').addClass('collapsible')

The resulting tab collapses just like it should.