Page MenuHomePhabricator

Lqt loads page text multiple times
Closed, ResolvedPublic

Description

When viewing old version of page Support at translatewiki.net, Lqt loads the Support page text 51 times! When the page finally loads after 70 or seconds, exception is thrown: "Thread 6475 purports to be moved, but no redirect found in text {...}" Each content load takes at least 4 queries, possibly due to r44442.

See http://translatewiki.net/static/slow.txt for debug output.


Version: unspecified
Severity: major

Details

Reference
bz24831

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 10:59 PM
bzimport set Reference to bz24831.
bzimport added a subscriber: Unknown Object (MLST).

Nx.devnull wrote:

If this is what I think it is, I have a fix for that.

Nx.devnull wrote:

Pass through TalkpageHeaderView wrapper on oldid

With this patch, LQT will not attempt to show the threads on the page when you view an oldid of the header, similar to viewing a diff for the header. Otherwise LQT would show all the threads *currently* on the talk page, but each comment would contain the old revision of the header, causing the massive slowdown.

Attached:

Nx.devnull wrote:

*** Bug 27076 has been marked as a duplicate of this bug. ***

*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*

sumanah wrote:

Marking with the need-review keyword since this patch is awaiting review. Thank you for the patch, Nikola.

Once again, spot on, Nikola! Thanks a lot.

Applied in r111187.