Page MenuHomePhabricator

Compatibility anchors cause unnecessary <p> tags
Closed, ResolvedPublic

Description

The compatibility anchors inserted when a header contains special characters are wrapped in <p> tags. The wikitext

áàâ

is rendered as

<p><a id=".C3.A1.C3.A0.C3.A2" name=".C3.A1.C3.A0.C3.A2"></a></p>
<h2><span class="mw-headline" id="áàâ">áàâ</span></h2>

Why are the <p> tags there? Probably because only block elements are allowed as children of the bodytext. But these paragraphs can affect rendering because they have top and bottom margins (which happen to collapse with other margins most of the times, but not necessarily always).

I'd prefer one of the following:

<div id=".C3.A1.C3.A0.C3.A2"></div>
<h2><span class="mw-headline" id="áàâ">áàâ</span></h2>

or

<h2><a id=".C3.A1.C3.A0.C3.A2" name=".C3.A1.C3.A0.C3.A2"></a>
<span class="mw-headline" id="áàâ">áàâ</span></h2>

Besides that, I don't see a reason for the name attribute? It is not valid in HTML5 (looks quite odd if something that has been added because of HTML5 breaks validation) and only needed by browsers of the Netscape 4 era. The real headers don't have named anchors either, so that's rather pointless.


Version: unspecified
Severity: enhancement

Details

Reference
bz24835

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:00 PM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz24835.
bzimport added a subscriber: Unknown Object (MLST).

ayg wrote:

Fixed in r71215. When I wrote this code long ago, I based it on the way the existing code looked, which IIRC was actually an <a> tag, which did get put in that silly paragraph. At some intervening point it changed. I made it a <div> as you suggested.

I didn't actually add a name attribute (see the diff). I assume there's some magic in the parser or Sanitizer or something that adds it, I dunno. name on <a> is conforming in HTML5, actually, although it raises a warning:

http://www.whatwg.org/specs/web-apps/current-work/multipage/obsolete.html#obsolete-but-conforming-features