Page MenuHomePhabricator

CR should give some sort of error messages when revision can't be found
Closed, ResolvedPublic

Description

When a revision can't be found[1], Code Review just dumps you back into the path folder showing the table review which can be confusing and should offer some sort of message explaining that the revision can't be found.

[1]. http://www.mediawiki.org/wiki/Special:Code/MediaWiki/cheese [2]
[2]. Which is impossible to happen due to revisions needing to be numbers, but if i used a number, Its possible that it can be done so this is only for demo purposes.


Version: unspecified
Severity: enhancement

Details

Reference
bz24840

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:00 PM
bzimport set Reference to bz24840.
bzimport added a subscriber: Unknown Object (MLST).
		if ( !$this->mRev ) {
			$view = new CodeRevisionListView( $this->mRepo->getName() );
			$view->execute();
			return;
		}

Could just poke in the following code into the if
'code-rev-not-found' => 'Revision<b>$1</b> does not exist!',

display it, and then do the fallback to the code revision list view?