Rollbacks improperly reported under race condition
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	• bzimport
	Aug 19 2010, 5:23 AM

Description

Author: Winbots

Description:
Fixes bug.

Rollbacks can be improperly reported under certain race conditions. Mainly because the doEdit call's status is never checked before notifying of a successful rollback.

The diff should fix this.

--Cobi.

Version: 1.17.x
Severity: enhancement

Attached:

racecondition.diff438 BDownload

Details

Reference: bz24866

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 21 2014, 11:02 PM

• bzimport added a project: MediaWiki-Page-editing.

• bzimport set Reference to bz24866.

• bzimport added a subscriber: Unknown Object (MLST).

• bzimport created this task.Aug 19 2010, 5:23 AM

Using the message "Cannot revert edit; last contributor is only author of this page." is bad. A new message should be added.

Also,
You should really have it with braces as per the coding style guidelines

if( !$status->isOK() ) {
return array( array( 'cantrollback' ) );
}

Bryan.TongMinh wrote:

Marking as reviewed per comment #2.

Check for $status->isOk was added with gerrit 21662

Rollbacks improperly reported under race conditionClosed, ResolvedPublicActions

Description

Details

Event Timeline

Rollbacks improperly reported under race condition
Closed, ResolvedPublic
Actions