Page MenuHomePhabricator

Is the seperate Spyc include needed
Closed, InvalidPublic

Description

The Api had a version of it in ApiFormatYaml_spypc or something. Tim stripped out a lot of crap from it (security or something).

Noticed you optionally include it

00077 public static function dump( $text ) {
00078 global $wgTranslateYamlLibrary;
00079
00080 switch ( $wgTranslateYamlLibrary ) {
00081 case 'spyc':
00082 require_once( dirname( FILE ) . '/../spyc/spyc.php' );
00083 return Spyc::YAMLDump( $text );
00084 case 'syck':
00085 return self::syckDump( $text );
00086 default:
00087 throw new MWException( "Unknown Yaml library" );
00088 }
00089 }

Do you still need a seperate version?


Version: unspecified
Severity: minor

Details

Reference
bz24952

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:07 PM
bzimport set Reference to bz24952.

The "lot of crap" happens to be the parsing of YAML files. The API version is very old, crippled to be unusable and has other unknown modifications (that probably never went to upstream. So yeah I can't and don't want to use it as it is now.