Page MenuHomePhabricator
Create Task
Maniphest T26972

Book editor panel must not use #siteNotice wrapper
Open, LowPublicFeature
Actions

Description

Book editor panel must not use #siteNotice wrapper.

  • It semantically does not belong there. #siteNotice is for site notices. Not for other things. Create new sibling after #siteNotice instead.
  • Lot of people turn off all notices by using display:none for #siteNotice which disables the panel.
  • Such wrapper has random styling on local wikis which may override default settings of the panel.

Version: unspecified
Severity: enhancement

Details

Reference
bz24972

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 21 2014, 11:08 PM
• bzimport added a project: Collection.
• bzimport set Reference to bz24972.
• bzimport added a subscriber: Unknown Object (MLST).
Danny_B created this task.Aug 28 2010, 8:53 PM
• bzimport added a comment.Aug 30 2010, 9:27 AM

johannes.beigel wrote:

We're actually using the hook SiteNoticeAfter to render that box, so the #siteNotice ID is inserted by core MediaWiki code. Any ideas what we could use instead?

• bzimport added a comment.Aug 19 2011, 7:12 PM

mhershberger wrote:

Unassigning default assignments. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/54734

• bzimport added a comment.Apr 25 2012, 8:14 AM

roland wrote:

This also causes trouble with http://www.mediawiki.org/wiki/Extension:DismissableSiteNotice
If both are enabled and the current SiteNotice was disabled per click, the book editor panel is completely missing.

• bzimport added a comment.Apr 25 2012, 2:10 PM

roland wrote:

Including DismissableSiteNotice before Collection works around the problem for these both extensions, but doesn't solve the main problem.

Nemo_bis mentioned this in T112161: Some other bugs with Firefox 37.0 and Vector skin on fr.wikiversity.Sep 26 2015, 1:59 PM
Aklapper changed the subtype of this task from "Task" to "Feature Request".Feb 4 2022, 11:00 AM
Aklapper removed a subscriber: • wikibugs-l-list.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL