Page MenuHomePhabricator

Thumbnailing errors for tiffs
Closed, ResolvedPublic

Description

I see three common problems in http://commons.wikimedia.org/wiki/Category:Tiff_files

1: Thumb of: "Error creating thumbnail: The uploaded file contains errors."
2: Empty thumb with: "Error generating thumbnail

Error creating thumbnail: The resolution of the source file is too large.
No thumbnail will be generated."

3: Thumb of: "Error creating thumbnail: Cannot get metadata from TIFF"

The latter can be solved by Purging the image by hand (dirty/non-existant serialized metadata ?). This last one can probably be fixed easily.


Version: unspecified
Severity: normal

Details

Reference
bz24984

Related Objects

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:09 PM
bzimport set Reference to bz24984.
bzimport added a subscriber: Unknown Object (MLST).

Another set of tiffs with trouble is http://commons.wikimedia.org/wiki/Category:Scanned_French_books_in_TIFF

For these it seems as if the dimensions cannot be detected or something.

problem 1: tiff_bad_file

Problem of 3, tiff_no_metadata, most likely originates in doTransform()'s $pagesize = PagedTiffImage::getPageSize($meta, $page);
A purge fixes this, because getMetaArray(), uses isMetadataValid(), but doesn't actually blank the previous metadata, instead just ignoring the situation, thus no automatic call of upgradeRow ??

I will look at this asap. Some tiff images cannot be rendered by the rendering engine. That's where the error messages come from. Metadata should be invalidated if there are errors and it is supposed to be recreated after some time. however, there have been some changes to that mechanism recently, so I need to do some investigations.

I downloaded a few images with metadata extraction issues. They were all created by Photoshop. The tiffinfo output in that case is pretty ugly, with tags with line breaks in them. Example:

http://commons.wikimedia.org/wiki/File:Circle-red2.tif

I see hardly any thumbnails rendering in http://commons.wikimedia.org/wiki/Category:Tiff_files - for most files, i still see the blank placeholder image. Looks like rendering isn't triggered. What gives?

partial fix in r72278: metadata processing is no longer aborted when a warning is encountered. This should fix problem no 1 from the original report: "uploaded file contains errors". I have not investigated the need to purge pages with "Cannot get metadata from TIFF".

RSYQFIOJGWZA wrote:

Currently, 13 of 104 images (12.5%) in http://commons.wikimedia.org/wiki/Category:TIFF_images (the new name for http://commons.wikimedia.org/wiki/Category:Tiff_files ) are not thumbnailing. :(

RSYQFIOJGWZA wrote:

(In reply to comment #8)

At least one of those is a PNG image, though:
http://commons.wikimedia.org/wiki/File:A_Leslie_Scott.tif

Thanks, I marked it with "{{duplicate|A Leslie Scott.png}}".

And for most of the others, the source resolution is simply too high. It's just that you don't get a nice html error in the thumbnail that states this (like PNGs do with the 12.5 Mpixel limit). It is visible if you open the thumbnail itself in the browser or in a texteditor.

Only File:London_Interdean_office.tif is rather weird in that it produces no error output at all.

http://commons.wikimedia.org/wiki/Category:Scanned_French_books_in_TIFF is also interesting, it doesn't generate thumbs nor errors there, but as to why, i'm unsure.

RSYQFIOJGWZA wrote:

A similar problem is in [[Commons:Category:Hermitage hi-res TIFF files from a .torrent]], where 11 of 15 images (73%) are not thumbnailing. If there is an exactly 12.5 megapixels (12,500,000 pixels) limit on thumnbnailing TIFF images (and/or others besides PNG images), please update [[Commons:Commons:First steps/Quality and description#Size_and_scaling]] to reflect the current reality and consider increasing that five year old limit.

RSYQFIOJGWZA wrote:

Let's try those links again:
[[Commons:Category:Hermitage hi-res TIFF files from a .torrent]] and
[[Commons:Commons:First steps/Quality and description#Size_and_scaling]]

(In reply to comment #11)

A similar problem is in [[Commons:Category:Hermitage hi-res TIFF files from a
.torrent]], where 11 of 15 images (73%) are not thumbnailing. If there is an
exactly 12.5 megapixels (12,500,000 pixels) limit on thumnbnailing TIFF images
(and/or others besides PNG images), please update [[Commons:Commons:First
steps/Quality and description#Size_and_scaling]] to reflect the current reality
and consider increasing that five year old limit.

It's a wiki, you can edit that page yourself.

The limit will be increased when VIPS support is added, i.e. bug 25990.

RSYQFIOJGWZA wrote:

(In reply to comment #13)

(In reply to comment #11)

A similar problem is in [[Commons:Category:Hermitage hi-res TIFF files from a
.torrent]], where 11 of 15 images (73%) are not thumbnailing. If there is an
exactly 12.5 megapixels (12,500,000 pixels) limit on thumbnailing TIFF images
(and/or others besides PNG images), please update [[Commons:Commons:First
steps/Quality and description#Size_and_scaling]] to reflect the current reality
and consider increasing that five year old limit.

It's a wiki, you can edit that page yourself.

Thank you, I did so in http://commons.wikimedia.org/w/index.php?title=Commons:First_steps/Quality_and_description&diff=49759608&oldid=49523951 . What other formats (if any) are subject to that limit?

The limit will be increased when VIPS support is added, i.e. bug 25990.

Thank you, that will be a welcome addition, as 21.1 megapixel cameras like the Canon EOS 5D Mark II are already available off the shelf. When do you expect that addition to take place? Thanks again.

  • This bug has been marked as a duplicate of bug 25647 ***
Gilles raised the priority of this task from Medium to Unbreak Now!.Dec 4 2014, 10:25 AM
Gilles added a project: Multimedia.
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Medium.Dec 4 2014, 11:21 AM