Page MenuHomePhabricator

Add pre commit hook to prevent blank commit summaries
Closed, ResolvedPublic

Description

As above


Version: unspecified
Severity: enhancement

Details

Reference
bz25025

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:10 PM
bzimport set Reference to bz25025.

jeluf wrote:

On which wiki?
Has the community discussed and approved this?

(In reply to comment #1)

On which wiki?
Has the community discussed and approved this?

On SVN not wiki, silly!.

I support this!

http://www.powertrip.co.za/blog/archives/pre-commit

Could work, tweaking the < 10 to be some value we'd like to set as minimum :)

Certainly seems to make some sense.

I'm sure there are very few use cases that a summary would be < 10 chars.

Unless we all become avar... Then it'll be many times greater than this ;)

"eol-style" and "typofix" are both less than 10, and both common commit summaries. I've also seen people do things like "b->a" to indicate a 1-letter change. I'd say as long as it's at least 3 characters or so we'd be fine. The main thing to rule out is empty commit summaries.

(Of course this does nothing to help people make their commit summaries *descriptive* of their changes, but that's a social problem)

Empty commit summaries are blocked now. Just used the example from pre-commit.tmpl :)

Why hasn't this been reopened already? :P

Fixed and re-deployed. See /trunk/tools/subversion/hooks.