leercontainer-bugzilla wrote:

Patch to LanguageNn.php against CVS HEAD (1.36) -u 3

Made with Winmerge and TortoiseCVS.

Attached:

avarab wrote:

(In reply to comment #0)

The patch has not been tested (don't have time for that), but I'd be grateful if
it could be tested on test.leuksman.com before deployment on Wikimedia servers.

I tested it on my local installation and made some tweaks to it among them
taking the liberty to implement commafy() which I think youl'll want.

Applied to HEAD, marking this as FIXED.

utne wrote:

The update was majorly edited by [[:nn:User:Dittaeva]], who is really good at the technical side of things. But there was not at all
enough time for me and others to do the necessary work on the language. PLEASE integrate the corrections made after the file was
uploaded!

Respectfully,

Olve Utne
([[:nn:User:Olve]])

avarab wrote:

(In reply to comment #3)

enough time for me and others to do the necessary work on the language. PLEASE

integrate the corrections made after the file was

uploaded!

And where would these corrections be?

jeluf wrote:

The patch includes hardcodes:

-'searchquery' => 'For førespurnad "$1"',
+'searchquery' => 'Du søkte etter «<a href="/wiki/$1">$1</a>» <a
href="/wiki/Special:Allpages/$1">[Indeks]</a>',

The href tags should not contain the path. This will not work if the wiki is not
installed to /wiki.

avarab wrote:

(In reply to comment #5)

The patch includes hardcodes:

-'searchquery' => 'For førespurnad "$1"',
+'searchquery' => 'Du søkte etter «<a href="/wiki/$1">$1</a>» <a
href="/wiki/Special:Allpages/$1">[Indeks]</a>',

The href tags should not contain the path. This will not work if the wiki is not
installed to /wiki.

Fixed in HEAD.

utne wrote:

The corrected version can be found on http://nn.wikipedia.org/wiki/Wikipedia:LanguageNn.php

Also: Isn't it correct to have this bug remain open as long as the version contains mistakes that need to be fixed?

• Olve

[[nn:Brukar:Olve]]

avarab wrote:

(In reply to comment #7)

The corrected version can be found on

http://nn.wikipedia.org/wiki/Wikipedia:LanguageNn.php

Could you please attach a patch against the current CVS, updating files from
wikipages is a [[PITA]].

utne wrote:

OK -- [[User:Dittaeva|Guttorm]] has uploaded an updated version on http://bugzilla.wikimedia.org/show_bug.cgi?id=2512

-Olve

http://nn.wikipedia.org/wiki/Brukar:Olve

avarab wrote:

Closing this one again since another bug has been opened.